Changeset 694

Show
Ignore:
Timestamp:
01/10/08 10:20:57 (7 months ago)
Author:
jlong
Message:

rails2: failing tests in page_controller_test.rb fixed

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/rails2/app/helpers/admin/node_helper.rb

    r589 r694  
    1414    unless @expanded_rows 
    1515      @expanded_rows = case 
    16       when row_string = (cookies['expanded_rows'] || []).first 
    17         row_string.split(',').map { |x| Integer(x) rescue nil }.compact 
     16      when rows = cookies['expanded_rows'] 
     17        rows.split(',').map { |x| Integer(x) rescue nil }.compact 
    1818      else 
    1919        [] 
  • branches/rails2/test/functional/admin/page_controller_test.rb

    r689 r694  
    4545 
    4646  def test_index__with_empty_cookie 
    47     @request.cookies['expanded_rows'] = [""] 
    48     get :index 
    49     assert_response :success 
     47    write_cookie('expanded_rows', '') 
     48    get :index 
     49    assert_response :success 
     50    assert '', cookies['expanded_rows'] 
    5051    assert_rendered_nodes_where { |page| [nil, 1].include?(page.parent_id) } 
    5152  end 
    5253 
    5354  def test_index__with_cookie 
    54     @request.cookies['expanded_rows'] = ["1,5,9,10,11,12,52"] 
    55     get :index 
    56     assert_response :success 
     55    write_cookie('expanded_rows', '1,5,9,10,11,12,52') 
     56    get :index 
     57    assert_response :success 
     58    assert '1,5,9,10,11,12,52', cookies['expanded_rows'] 
    5759    assert_rendered_nodes_where { |page| [nil, 1, 5, 9, 52, 10, 11, 12].include?(page.parent_id) } 
    5860  end 
    5961   
    6062  def test_index__with_mangled_cookie 
    61     @request.cookies['expanded_rows'] = ["1,5,:#*)&},9a,,,"] 
    62     get :index 
    63     assert_response :success 
     63    write_cookie('expanded_rows', '1,5,:#*)&},9a,,,') 
     64    get :index 
     65    assert_response :success 
     66    assert '1,5,:#*)&},9a,,,', cookies['expanded_rows'] 
    6467    assert_rendered_nodes_where { |page| [nil, 1, 5].include?(page.parent_id) } 
    6568    assert !assigns(:homepage).nil? 
     
    299302      end 
    300303    end 
     304     
     305    def write_cookie(name, value) 
     306      @request.cookies[name] = CGI::Cookie.new(name, value) 
     307    end 
    301308end