Changeset 715

Show
Ignore:
Timestamp:
02/01/08 14:00:02 (7 months ago)
Author:
mislav
Message:

minor optimization for Page; remove the unneccessary 'virtual' accessor

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/rails2/app/models/page.rb

    r628 r715  
    8686  def status=(value) 
    8787    self.status_id = value.id 
    88   end 
    89    
    90   def virtual 
    91     !(read_attribute('virtual').to_s =~ /^(false|f|0|)$/) 
    9288  end 
    9389   
     
    222218   
    223219    def update_published_at 
    224       write_attribute('published_at', Time.now) if (status_id.to_i == Status[:published].id) and published_at.nil? 
     220      write_attribute(:published_at, Time.now) if published? and !published_at 
    225221      true 
    226222    end 
    227223     
    228224    def update_virtual 
    229       if self.class != Page.descendant_class(class_name) 
    230         write_attribute('virtual', Page.descendant_class(class_name).new.virtual?) 
     225      unless self.class == Page.descendant_class(class_name) 
     226        self.virtual = Page.descendant_class(class_name).new.virtual? 
    231227      else 
    232         write_attribute('virtual', virtual?) 
     228        self.virtual = virtual? 
    233229      end 
    234230      true