Ticket #615 (closed enhancement: fixed)

Opened 5 months ago

Last modified 5 months ago

[PATCH] fix failing unit test r760

Reported by: matt@jupiter-labs.com Assigned to: seancribbs
Priority: minor Milestone: 0.6.5-Chisel
Component: core Keywords:
Cc:

Description

There was a failing unit test and the reason it was failing was because there were cache files that were not cleaned up before the test.

/opt/local/bin/ruby -S script/spec -O spec/spec.opts  spec/lib/login_system_spec.rb spec/models/page_part_spec.rb spec/controllers/admin/user_controller_spec.rb spec/lib/radiant/extension_spec.rb spec/lib/radiant/admin_ui_spec.rb spec/models/page_context_spec.rb spec/lib/radiant_spec.rb spec/lib/local_time_spec.rb spec/models/user_spec.rb spec/models/user_action_observer_spec.rb spec/controllers/admin/page_controller_spec.rb spec/lib/radiant/initializer_spec.rb spec/controllers/site_controller_spec.rb spec/lib/radiant/extension_migrator_spec.rb spec/lib/simpleton_spec.rb spec/lib/annotatable_spec.rb spec/models/text_filter_spec.rb spec/models/response_cache_spec.rb spec/models/file_not_found_page_spec.rb spec/models/standard_tags_spec.rb spec/models/status_spec.rb spec/lib/method_observer_spec.rb spec/models/page_spec.rb spec/lib/radiant/taggable_spec.rb spec/models/snippet_spec.rb spec/models/layout_spec.rb spec/controllers/application_controller_spec.rb spec/controllers/admin/welcome_controller_spec.rb spec/lib/inheritable_class_attributes_spec.rb spec/lib/radiant/extension_loader_spec.rb
..................................................................................................................................................................................................................................................................................................................................................PP........................................................................................................F....

Pending:
Admin::PageController should index__with_mangled_cookie (Not Yet Implemented)
Admin::PageController should show the tree partially expanded on the index according to the expanded_rows cookie (Not Yet Implemented)

1)
'SiteController routes page requests should redirect to admin if missing root' FAILED
expected redirect to "http://test.host/admin/welcome", got no redirect
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/expectations.rb:52:in `fail_with'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/expectations/handler.rb:21:in `handle_matcher'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in `should'
./spec/controllers/site_controller_spec.rb:33:
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in `instance_eval'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in `run_with_description_capturing'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_methods.rb:19:in `execute'
/opt/local/lib/ruby/1.8/timeout.rb:48:in `timeout'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_methods.rb:16:in `execute'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:292:in `execute_examples'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in `each'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in `execute_examples'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:121:in `run'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:22:in `run'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `each'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `run'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/runner/options.rb:90:in `run_examples'
/Users/matt/radiant/vendor/plugins/rspec/lib/spec/runner/command_line.rb:19:in `run'
script/spec:12:

Finished in 19.751113 seconds

Attachments

r760-fix-failing-unit-test.diff (0.5 kB) - added by matt@jupiter-labs.com on 02/23/08 17:43:11.

Change History

02/23/08 17:43:11 changed by matt@jupiter-labs.com

  • attachment r760-fix-failing-unit-test.diff added.

02/23/08 17:57:24 changed by seancribbs

  • owner set to seancribbs.
  • status changed from new to assigned.
  • milestone set to 0.6.5-Chisel.

02/23/08 18:02:23 changed by mislav

  • status changed from assigned to closed.
  • resolution set to fixed.

Thanks! [761]